Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: content/plugin/webplugin_delegate_stub.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/plugin/plugin_thread.h ('k') | content/plugin/webplugin_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_ 5 #ifndef CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_
6 #define CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_ 6 #define CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 // IPC::Message::Sender implementation: 49 // IPC::Message::Sender implementation:
50 virtual bool Send(IPC::Message* msg); 50 virtual bool Send(IPC::Message* msg);
51 51
52 int instance_id() { return instance_id_; } 52 int instance_id() { return instance_id_; }
53 WebPluginProxy* webplugin() { return webplugin_; } 53 WebPluginProxy* webplugin() { return webplugin_; }
54 54
55 private: 55 private:
56 friend class base::RefCounted<WebPluginDelegateStub>; 56 friend class base::RefCounted<WebPluginDelegateStub>;
57 57
58 ~WebPluginDelegateStub(); 58 virtual ~WebPluginDelegateStub();
59 59
60 // Message handlers for the WebPluginDelegate calls that are proxied from the 60 // Message handlers for the WebPluginDelegate calls that are proxied from the
61 // renderer over the IPC channel. 61 // renderer over the IPC channel.
62 void OnInit(const PluginMsg_Init_Params& params, bool* result); 62 void OnInit(const PluginMsg_Init_Params& params, bool* result);
63 void OnWillSendRequest(int id, const GURL& url, int http_status_code); 63 void OnWillSendRequest(int id, const GURL& url, int http_status_code);
64 void OnDidReceiveResponse(const PluginMsg_DidReceiveResponseParams& params); 64 void OnDidReceiveResponse(const PluginMsg_DidReceiveResponseParams& params);
65 void OnDidReceiveData(int id, const std::vector<char>& buffer, 65 void OnDidReceiveData(int id, const std::vector<char>& buffer,
66 int data_offset); 66 int data_offset);
67 void OnDidFinishLoading(int id); 67 void OnDidFinishLoading(int id);
68 void OnDidFail(int id); 68 void OnDidFail(int id);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 // window handle which is used for subsequent communication back to the 120 // window handle which is used for subsequent communication back to the
121 // browser. 121 // browser.
122 void OnSetFakeAcceleratedSurfaceWindowHandle(gfx::PluginWindowHandle window); 122 void OnSetFakeAcceleratedSurfaceWindowHandle(gfx::PluginWindowHandle window);
123 #endif 123 #endif
124 #endif 124 #endif
125 125
126 DISALLOW_IMPLICIT_CONSTRUCTORS(WebPluginDelegateStub); 126 DISALLOW_IMPLICIT_CONSTRUCTORS(WebPluginDelegateStub);
127 }; 127 };
128 128
129 #endif // CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_ 129 #endif // CONTENT_PLUGIN_WEBPLUGIN_DELEGATE_STUB_H_
OLDNEW
« no previous file with comments | « content/plugin/plugin_thread.h ('k') | content/plugin/webplugin_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698