Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/history/history_types.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 327 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 338
339 // URLResult ------------------------------------------------------------------- 339 // URLResult -------------------------------------------------------------------
340 340
341 class URLResult : public URLRow { 341 class URLResult : public URLRow {
342 public: 342 public:
343 URLResult(); 343 URLResult();
344 URLResult(const GURL& url, base::Time visit_time); 344 URLResult(const GURL& url, base::Time visit_time);
345 // Constructor that create a URLResult from the specified URL and title match 345 // Constructor that create a URLResult from the specified URL and title match
346 // positions from title_matches. 346 // positions from title_matches.
347 URLResult(const GURL& url, const Snippet::MatchPositions& title_matches); 347 URLResult(const GURL& url, const Snippet::MatchPositions& title_matches);
348 ~URLResult(); 348 virtual ~URLResult();
349 349
350 base::Time visit_time() const { return visit_time_; } 350 base::Time visit_time() const { return visit_time_; }
351 void set_visit_time(base::Time visit_time) { visit_time_ = visit_time; } 351 void set_visit_time(base::Time visit_time) { visit_time_ = visit_time; }
352 352
353 const Snippet& snippet() const { return snippet_; } 353 const Snippet& snippet() const { return snippet_; }
354 354
355 // If this is a title match, title_match_positions contains an entry for 355 // If this is a title match, title_match_positions contains an entry for
356 // every word in the title that matched one of the query parameters. Each 356 // every word in the title that matched one of the query parameters. Each
357 // entry contains the start and end of the match. 357 // entry contains the start and end of the match.
358 const Snippet::MatchPositions& title_match_positions() const { 358 const Snippet::MatchPositions& title_match_positions() const {
(...skipping 376 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 // The icon's URL. 735 // The icon's URL.
736 GURL icon_url; 736 GURL icon_url;
737 737
738 // The type of favicon. 738 // The type of favicon.
739 history::IconType icon_type; 739 history::IconType icon_type;
740 }; 740 };
741 741
742 } // namespace history 742 } // namespace history
743 743
744 #endif // CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_ 744 #endif // CHROME_BROWSER_HISTORY_HISTORY_TYPES_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/history_notifications.h ('k') | chrome/browser/history/in_memory_history_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698