webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h

diff --git a/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h b/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h

index 12cf4e2f49d3b3f2d1f6d2d6a1a2d4a86a1d3ab4..8365b9b3fc6e29c3aaf9ec7109bf675e86cdd83d 100644

--- a/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h

+++ b/webkit/plugins/npapi/test/plugin_npobject_lifetime_test.h

@@ -41,7 +41,7 @@ class NPObjectLifetimeTestInstance2 : public PluginTest {

public:

// Constructor.

NPObjectLifetimeTestInstance2(NPP id, NPNetscapeFuncs *host_functions);

- ~NPObjectLifetimeTestInstance2();

+ virtual ~NPObjectLifetimeTestInstance2();

// NPAPI SetWindow handler.

virtual NPError SetWindow(NPWindow* pNPWindow);

@@ -58,7 +58,7 @@ class NPObjectDeletePluginInNPN_Evaluate : public PluginTest {

public:

// Constructor.

NPObjectDeletePluginInNPN_Evaluate(NPP id, NPNetscapeFuncs *host_functions);

- ~NPObjectDeletePluginInNPN_Evaluate();

+ virtual ~NPObjectDeletePluginInNPN_Evaluate();

// NPAPI SetWindow handler.

virtual NPError SetWindow(NPWindow* pNPWindow);