net/disk_cache/stats_histogram.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/stats_histogram.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/stats_histogram.h

diff --git a/net/disk_cache/stats_histogram.h b/net/disk_cache/stats_histogram.h

index 83d359c1473ef754702057a7cff6de85b2f6e97f..7f513ce296b418109dc5e7abe34b3eb5a90b1a4b 100644

--- a/net/disk_cache/stats_histogram.h

+++ b/net/disk_cache/stats_histogram.h

@@ -33,7 +33,7 @@ class StatsHistogram : public base::Histogram {

explicit StatsHistogram(const std::string& name, Sample minimum,

Sample maximum, size_t bucket_count)

: Histogram(name, minimum, maximum, bucket_count), init_(false) {}

- ~StatsHistogram();

+ virtual ~StatsHistogram();

static StatsHistogram* StatsHistogramFactoryGet(const std::string& name);

« no previous file with comments | « net/disk_cache/mem_entry_impl.h ('k') | net/ftp/ftp_network_layer.h » ('j') | no next file with comments »