Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7765)

Unified Diff: chrome/browser/extensions/extension_page_actions_module.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_page_actions_module.h
diff --git a/chrome/browser/extensions/extension_page_actions_module.h b/chrome/browser/extensions/extension_page_actions_module.h
index ee99906e99c5a8ce1a28501bcdb7edb791289a2b..658538236f8660d7818fe42e318a8a5002a96e45 100644
--- a/chrome/browser/extensions/extension_page_actions_module.h
+++ b/chrome/browser/extensions/extension_page_actions_module.h
@@ -26,70 +26,70 @@ class PageActionFunction : public SyncExtensionFunction {
// Implement chrome.pageActions.enableForTab().
class EnablePageActionFunction : public PageActionFunction {
- ~EnablePageActionFunction() {}
+ virtual ~EnablePageActionFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageActions.enableForTab")
};
// Implement chrome.pageActions.disableForTab().
class DisablePageActionFunction : public PageActionFunction {
- ~DisablePageActionFunction() {}
+ virtual ~DisablePageActionFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageActions.disableForTab")
};
// Implement chrome.pageActions.show().
class PageActionShowFunction : public PageActionFunction {
- ~PageActionShowFunction() {}
+ virtual ~PageActionShowFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.show")
};
// Implement chrome.pageActions.hide().
class PageActionHideFunction : public PageActionFunction {
- ~PageActionHideFunction() {}
+ virtual ~PageActionHideFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.hide")
};
// Implement chrome.pageActions.setIcon().
class PageActionSetIconFunction : public PageActionFunction {
- ~PageActionSetIconFunction() {}
+ virtual ~PageActionSetIconFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setIcon")
};
// Implement chrome.pageActions.setTitle().
class PageActionSetTitleFunction : public PageActionFunction {
- ~PageActionSetTitleFunction() {}
+ virtual ~PageActionSetTitleFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setTitle")
};
// Implement chrome.pageActions.setPopup().
class PageActionSetPopupFunction : public PageActionFunction {
- ~PageActionSetPopupFunction() {}
+ virtual ~PageActionSetPopupFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setPopup")
};
// Implement chrome.pageActions.setBadgeBackgroundColor().
class PageActionSetBadgeBackgroundColorFunction : public PageActionFunction {
- ~PageActionSetBadgeBackgroundColorFunction() {}
+ virtual ~PageActionSetBadgeBackgroundColorFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeBackgroundColor")
};
// Implement chrome.pageActions.setBadgeTextColor().
class PageActionSetBadgeTextColorFunction : public PageActionFunction {
- ~PageActionSetBadgeTextColorFunction() {}
+ virtual ~PageActionSetBadgeTextColorFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeTextColor")
};
// Implement chrome.pageActions.setBadgeText().
class PageActionSetBadgeTextFunction : public PageActionFunction {
- ~PageActionSetBadgeTextFunction() {}
+ virtual ~PageActionSetBadgeTextFunction() {}
virtual bool RunImpl();
DECLARE_EXTENSION_FUNCTION_NAME("pageAction.setBadgeText")
};
« no previous file with comments | « chrome/browser/extensions/extension_management_api.h ('k') | chrome/browser/extensions/extension_tabs_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698