Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2752)

Unified Diff: chrome/browser/file_select_helper.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service.h ('k') | chrome/browser/history/history.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/file_select_helper.h
diff --git a/chrome/browser/file_select_helper.h b/chrome/browser/file_select_helper.h
index 270c8aac3f937cf97b3e34e1eb8940b608f771cb..a01371571f108e5f5830178919a71ddfe45593e0 100644
--- a/chrome/browser/file_select_helper.h
+++ b/chrome/browser/file_select_helper.h
@@ -29,7 +29,7 @@ class FileSelectHelper
public NotificationObserver {
public:
explicit FileSelectHelper(Profile* profile);
- ~FileSelectHelper();
+ virtual ~FileSelectHelper();
// Show the file chooser dialog.
void RunFileChooser(RenderViewHost* render_view_host,
@@ -50,7 +50,7 @@ class FileSelectHelper
DirectoryListerDispatchDelegate(FileSelectHelper* parent, int id)
: parent_(parent),
id_(id) {}
- ~DirectoryListerDispatchDelegate() {}
+ virtual ~DirectoryListerDispatchDelegate() {}
virtual void OnListFile(
const net::DirectoryLister::DirectoryListerData& data) {
parent_->OnListFile(id_, data);
@@ -123,7 +123,7 @@ class FileSelectHelper
class FileSelectObserver : public TabContentsObserver {
public:
explicit FileSelectObserver(TabContents* tab_contents);
- ~FileSelectObserver();
+ virtual ~FileSelectObserver();
private:
// TabContentsObserver overrides.
« no previous file with comments | « chrome/browser/favicon/favicon_service.h ('k') | chrome/browser/history/history.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698