chrome/browser/history/history_types.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_types.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_types.h

diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h

index 6a3e553dbbd49f1fce1887208d49eed5d4373851..6d4925b579b58bd4ebf1d5dfca5b0a53df7c0df5 100644

--- a/chrome/browser/history/history_types.h

+++ b/chrome/browser/history/history_types.h

@@ -345,7 +345,7 @@ class URLResult : public URLRow {

// Constructor that create a URLResult from the specified URL and title match

// positions from title_matches.

URLResult(const GURL& url, const Snippet::MatchPositions& title_matches);

- ~URLResult();

+ virtual ~URLResult();

base::Time visit_time() const { return visit_time_; }

void set_visit_time(base::Time visit_time) { visit_time_ = visit_time; }