Virtual destructors should have virtual keyword.

chrome/browser/sync/glue/generic_change_processor.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_GENERIC_CHANGE_PROCESSOR_H_
 #define CHROME_BROWSER_SYNC_GLUE_GENERIC_CHANGE_PROCESSOR_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 14 matching lines @@
 // is created for each datatype and lives on the datatype's thread. It then
 // handles all interaction with the sync api, both translating pushes from the
 // local service into transactions and receiving changes from the sync model,
 // which then get converted into SyncChange's and sent to the local service.
 class GenericChangeProcessor : public ChangeProcessor,
                                public SyncChangeProcessor {
  public:
   GenericChangeProcessor(SyncableService* local_service,
                          UnrecoverableErrorHandler* error_handler,
                          sync_api::UserShare* user_share);
-  ~GenericChangeProcessor();
+  virtual ~GenericChangeProcessor();
 
   // ChangeProcessor interface.
   // Build and store a list of all changes into |syncer_changes_|.
   virtual void ApplyChangesFromSyncModel(
       const sync_api::BaseTransaction* trans,
       const sync_api::SyncManager::ChangeRecord* changes,
       int change_count) OVERRIDE;
   // Passes |syncer_changes_|, built in ApplyChangesFromSyncModel, onto
   // |local_service_| by way of it's ProcessSyncChanges method.
   virtual void CommitChangesFromSyncModel() OVERRIDE;
@@ skipping 29 matching lines @@
   // be able to access the sync model before the change processor begins
   // listening to changes (the local_service_ will be interacting with us
   // when it starts up). As such we can't wait until Start(_) has been called,
   // and have to keep a local pointer to the user_share.
   sync_api::UserShare* user_share_;
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_GENERIC_CHANGE_PROCESSOR_H_