Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Side by Side Diff: webkit/plugins/npapi/webplugin_delegate_impl.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_ 5 #ifndef WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_
6 #define WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_ 6 #define WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 #include <list> 9 #include <list>
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 windowless_shm_pixmap_ = shm_pixmap; 194 windowless_shm_pixmap_ = shm_pixmap;
195 } 195 }
196 #endif 196 #endif
197 197
198 private: 198 private:
199 friend class DeleteTask<WebPluginDelegateImpl>; 199 friend class DeleteTask<WebPluginDelegateImpl>;
200 friend class WebPluginDelegate; 200 friend class WebPluginDelegate;
201 201
202 WebPluginDelegateImpl(gfx::PluginWindowHandle containing_view, 202 WebPluginDelegateImpl(gfx::PluginWindowHandle containing_view,
203 PluginInstance *instance); 203 PluginInstance *instance);
204 ~WebPluginDelegateImpl(); 204 virtual ~WebPluginDelegateImpl();
205 205
206 // Called by Initialize() for platform-specific initialization. 206 // Called by Initialize() for platform-specific initialization.
207 // If this returns false, the plugin shouldn't be started--see Initialize(). 207 // If this returns false, the plugin shouldn't be started--see Initialize().
208 bool PlatformInitialize(); 208 bool PlatformInitialize();
209 209
210 // Called by DestroyInstance(), used for platform-specific destruction. 210 // Called by DestroyInstance(), used for platform-specific destruction.
211 void PlatformDestroyInstance(); 211 void PlatformDestroyInstance();
212 212
213 //-------------------------- 213 //--------------------------
214 // used for windowed plugins 214 // used for windowed plugins
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 // True if NPP_New did not return an error. 512 // True if NPP_New did not return an error.
513 bool creation_succeeded_; 513 bool creation_succeeded_;
514 514
515 DISALLOW_COPY_AND_ASSIGN(WebPluginDelegateImpl); 515 DISALLOW_COPY_AND_ASSIGN(WebPluginDelegateImpl);
516 }; 516 };
517 517
518 } // namespace npapi 518 } // namespace npapi
519 } // namespace webkit 519 } // namespace webkit
520 520
521 #endif // WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_ 521 #endif // WEBKIT_PLUGINS_NPAPI_WEBPLUGIN_DELEGATE_IMPL_H_
OLDNEW
« no previous file with comments | « webkit/plugins/npapi/test/plugin_thread_async_call_test.h ('k') | webkit/plugins/ppapi/ppb_audio_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698