Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: content/plugin/npobject_proxy.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/gpu/gpu_process.h ('k') | content/plugin/npobject_stub.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A proxy for NPObject that sends all calls to the object to an NPObjectStub 5 // A proxy for NPObject that sends all calls to the object to an NPObjectStub
6 // running in a different process. 6 // running in a different process.
7 7
8 #ifndef CONTENT_PLUGIN_NPOBJECT_PROXY_H_ 8 #ifndef CONTENT_PLUGIN_NPOBJECT_PROXY_H_
9 #define CONTENT_PLUGIN_NPOBJECT_PROXY_H_ 9 #define CONTENT_PLUGIN_NPOBJECT_PROXY_H_
10 #pragma once 10 #pragma once
(...skipping 13 matching lines...) Expand all
24 // as a plugin can get an NPObject for the window, and a page can get an 24 // as a plugin can get an NPObject for the window, and a page can get an
25 // NPObject for the plugin. In the process that interacts with the NPobject we 25 // NPObject for the plugin. In the process that interacts with the NPobject we
26 // give it an NPObjectProxy instead. All calls to it are sent across an IPC 26 // give it an NPObjectProxy instead. All calls to it are sent across an IPC
27 // channel (specifically, a PluginChannelBase). The NPObjectStub on the other 27 // channel (specifically, a PluginChannelBase). The NPObjectStub on the other
28 // side translates the IPC messages into calls to the actual NPObject, and 28 // side translates the IPC messages into calls to the actual NPObject, and
29 // returns the marshalled result. 29 // returns the marshalled result.
30 class NPObjectProxy : public IPC::Channel::Listener, 30 class NPObjectProxy : public IPC::Channel::Listener,
31 public IPC::Message::Sender, 31 public IPC::Message::Sender,
32 public NPObjectBase { 32 public NPObjectBase {
33 public: 33 public:
34 ~NPObjectProxy(); 34 virtual ~NPObjectProxy();
35 35
36 static NPObject* Create(PluginChannelBase* channel, 36 static NPObject* Create(PluginChannelBase* channel,
37 int route_id, 37 int route_id,
38 gfx::NativeViewId containing_window, 38 gfx::NativeViewId containing_window,
39 const GURL& page_url); 39 const GURL& page_url);
40 40
41 // IPC::Message::Sender implementation: 41 // IPC::Message::Sender implementation:
42 virtual bool Send(IPC::Message* msg); 42 virtual bool Send(IPC::Message* msg);
43 int route_id() { return route_id_; } 43 int route_id() { return route_id_; }
44 PluginChannelBase* channel() { return channel_; } 44 PluginChannelBase* channel() { return channel_; }
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 114
115 scoped_refptr<PluginChannelBase> channel_; 115 scoped_refptr<PluginChannelBase> channel_;
116 int route_id_; 116 int route_id_;
117 gfx::NativeViewId containing_window_; 117 gfx::NativeViewId containing_window_;
118 118
119 // The url of the main frame hosting the plugin. 119 // The url of the main frame hosting the plugin.
120 GURL page_url_; 120 GURL page_url_;
121 }; 121 };
122 122
123 #endif // CONTENT_PLUGIN_NPOBJECT_PROXY_H_ 123 #endif // CONTENT_PLUGIN_NPOBJECT_PROXY_H_
OLDNEW
« no previous file with comments | « content/gpu/gpu_process.h ('k') | content/plugin/npobject_stub.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698