Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: chrome/browser/favicon/favicon_service.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/user_script_listener.h ('k') | chrome/browser/file_select_helper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 5 #ifndef CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 6 #define CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 87
88 // Sets the favicon for a page. 88 // Sets the favicon for a page.
89 void SetFavicon(const GURL& page_url, 89 void SetFavicon(const GURL& page_url,
90 const GURL& icon_url, 90 const GURL& icon_url,
91 const std::vector<unsigned char>& image_data, 91 const std::vector<unsigned char>& image_data,
92 history::IconType icon_type); 92 history::IconType icon_type);
93 93
94 private: 94 private:
95 friend class base::RefCountedThreadSafe<FaviconService>; 95 friend class base::RefCountedThreadSafe<FaviconService>;
96 96
97 ~FaviconService(); 97 virtual ~FaviconService();
98 98
99 Profile* profile_; 99 Profile* profile_;
100 100
101 // Helper to forward an empty result if we cannot get the history service. 101 // Helper to forward an empty result if we cannot get the history service.
102 void ForwardEmptyResultAsync(GetFaviconRequest* request); 102 void ForwardEmptyResultAsync(GetFaviconRequest* request);
103 103
104 DISALLOW_COPY_AND_ASSIGN(FaviconService); 104 DISALLOW_COPY_AND_ASSIGN(FaviconService);
105 }; 105 };
106 106
107 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_ 107 #endif // CHROME_BROWSER_FAVICON_FAVICON_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/user_script_listener.h ('k') | chrome/browser/file_select_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698