Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: webkit/appcache/appcache_disk_cache.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « skia/ext/vector_platform_device_skia.h ('k') | webkit/appcache/appcache_host.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_ 5 #ifndef WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_
6 #define WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_ 6 #define WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 class CreateBackendCallback 50 class CreateBackendCallback
51 : public net::CancelableCompletionCallback<AppCacheDiskCache> { 51 : public net::CancelableCompletionCallback<AppCacheDiskCache> {
52 public: 52 public:
53 typedef net::CancelableCompletionCallback<AppCacheDiskCache> BaseClass; 53 typedef net::CancelableCompletionCallback<AppCacheDiskCache> BaseClass;
54 CreateBackendCallback(AppCacheDiskCache* object, 54 CreateBackendCallback(AppCacheDiskCache* object,
55 void (AppCacheDiskCache::* method)(int)) 55 void (AppCacheDiskCache::* method)(int))
56 : BaseClass(object, method), backend_ptr_(NULL) {} 56 : BaseClass(object, method), backend_ptr_(NULL) {}
57 57
58 disk_cache::Backend* backend_ptr_; // Accessed directly. 58 disk_cache::Backend* backend_ptr_; // Accessed directly.
59 private: 59 private:
60 ~CreateBackendCallback() { 60 virtual ~CreateBackendCallback() {
61 delete backend_ptr_; 61 delete backend_ptr_;
62 } 62 }
63 }; 63 };
64 64
65 enum PendingCallType { 65 enum PendingCallType {
66 CREATE, 66 CREATE,
67 OPEN, 67 OPEN,
68 DOOM 68 DOOM
69 }; 69 };
70 struct PendingCall { 70 struct PendingCall {
(...skipping 23 matching lines...) Expand all
94 net::CompletionCallback* init_callback_; 94 net::CompletionCallback* init_callback_;
95 scoped_refptr<CreateBackendCallback> create_backend_callback_; 95 scoped_refptr<CreateBackendCallback> create_backend_callback_;
96 PendingCalls pending_calls_; 96 PendingCalls pending_calls_;
97 scoped_ptr<disk_cache::Backend> disk_cache_; 97 scoped_ptr<disk_cache::Backend> disk_cache_;
98 }; 98 };
99 99
100 } // namespace appcache 100 } // namespace appcache
101 101
102 #endif // WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_ 102 #endif // WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_
103 103
OLDNEW
« no previous file with comments | « skia/ext/vector_platform_device_skia.h ('k') | webkit/appcache/appcache_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698