webkit/plugins/npapi/webplugin_delegate_impl.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/webplugin_delegate_impl.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/webplugin_delegate_impl.h

diff --git a/webkit/plugins/npapi/webplugin_delegate_impl.h b/webkit/plugins/npapi/webplugin_delegate_impl.h

index 039bb238f8e45c53220e0434e60af6b1cc85e324..b5156e30f5a057641f58d8f148cbd0fee91707d6 100644

--- a/webkit/plugins/npapi/webplugin_delegate_impl.h

+++ b/webkit/plugins/npapi/webplugin_delegate_impl.h

@@ -201,7 +201,7 @@ class WebPluginDelegateImpl : public WebPluginDelegate {

WebPluginDelegateImpl(gfx::PluginWindowHandle containing_view,

PluginInstance *instance);

- ~WebPluginDelegateImpl();

+ virtual ~WebPluginDelegateImpl();

// Called by Initialize() for platform-specific initialization.

// If this returns false, the plugin shouldn't be started--see Initialize().