Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: net/disk_cache/stats_histogram.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/disk_cache/mem_entry_impl.h ('k') | net/ftp/ftp_network_layer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_DISK_CACHE_STATS_HISTOGRAM_H_ 5 #ifndef NET_DISK_CACHE_STATS_HISTOGRAM_H_
6 #define NET_DISK_CACHE_STATS_HISTOGRAM_H_ 6 #define NET_DISK_CACHE_STATS_HISTOGRAM_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 15 matching lines...) Expand all
26 class StatsSamples : public SampleSet { 26 class StatsSamples : public SampleSet {
27 public: 27 public:
28 Counts* GetCounts() { 28 Counts* GetCounts() {
29 return &counts_; 29 return &counts_;
30 } 30 }
31 }; 31 };
32 32
33 explicit StatsHistogram(const std::string& name, Sample minimum, 33 explicit StatsHistogram(const std::string& name, Sample minimum,
34 Sample maximum, size_t bucket_count) 34 Sample maximum, size_t bucket_count)
35 : Histogram(name, minimum, maximum, bucket_count), init_(false) {} 35 : Histogram(name, minimum, maximum, bucket_count), init_(false) {}
36 ~StatsHistogram(); 36 virtual ~StatsHistogram();
37 37
38 static StatsHistogram* StatsHistogramFactoryGet(const std::string& name); 38 static StatsHistogram* StatsHistogramFactoryGet(const std::string& name);
39 39
40 // We'll be reporting data from the given set of cache stats. 40 // We'll be reporting data from the given set of cache stats.
41 bool Init(const Stats* stats); 41 bool Init(const Stats* stats);
42 42
43 virtual Sample ranges(size_t i) const; 43 virtual Sample ranges(size_t i) const;
44 virtual size_t bucket_count() const; 44 virtual size_t bucket_count() const;
45 virtual void SnapshotSample(SampleSet* sample) const; 45 virtual void SnapshotSample(SampleSet* sample) const;
46 virtual Inconsistencies FindCorruption(const SampleSet& snapshot) const; 46 virtual Inconsistencies FindCorruption(const SampleSet& snapshot) const;
47 virtual uint32 CalculateRangeChecksum() const; 47 virtual uint32 CalculateRangeChecksum() const;
48 48
49 private: 49 private:
50 bool init_; 50 bool init_;
51 static const Stats* stats_; 51 static const Stats* stats_;
52 DISALLOW_COPY_AND_ASSIGN(StatsHistogram); 52 DISALLOW_COPY_AND_ASSIGN(StatsHistogram);
53 }; 53 };
54 54
55 } // namespace disk_cache 55 } // namespace disk_cache
56 56
57 #endif // NET_DISK_CACHE_STATS_HISTOGRAM_H_ 57 #endif // NET_DISK_CACHE_STATS_HISTOGRAM_H_
OLDNEW
« no previous file with comments | « net/disk_cache/mem_entry_impl.h ('k') | net/ftp/ftp_network_layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698