chrome/browser/extensions/extension_history_api.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_history_api.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_history_api.h

diff --git a/chrome/browser/extensions/extension_history_api.h b/chrome/browser/extensions/extension_history_api.h

index d51c3f44211484a020b01193c834ca5f76774648..f6ddcdc5de0fea4e499dc836ac859bdca6fd6e97 100644

--- a/chrome/browser/extensions/extension_history_api.h

+++ b/chrome/browser/extensions/extension_history_api.h

@@ -72,7 +72,7 @@ class HistoryFunction : public AsyncExtensionFunction {

class HistoryFunctionWithCallback : public HistoryFunction {

public:

HistoryFunctionWithCallback();

- ~HistoryFunctionWithCallback();

+ virtual ~HistoryFunctionWithCallback();

// Return true if the async call was completed, false otherwise.

virtual bool RunAsyncImpl() = 0;