Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: content/renderer/webplugin_delegate_proxy.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/renderer_webidbobjectstore_impl.h ('k') | content/renderer/webworker_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_ 5 #ifndef CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_
6 #define CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_ 6 #define CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 virtual void InstallMissingPlugin(); 116 virtual void InstallMissingPlugin();
117 virtual webkit::npapi::WebPluginResourceClient* CreateResourceClient( 117 virtual webkit::npapi::WebPluginResourceClient* CreateResourceClient(
118 unsigned long resource_id, const GURL& url, int notify_id); 118 unsigned long resource_id, const GURL& url, int notify_id);
119 virtual webkit::npapi::WebPluginResourceClient* CreateSeekableResourceClient( 119 virtual webkit::npapi::WebPluginResourceClient* CreateSeekableResourceClient(
120 unsigned long resource_id, int range_request_id); 120 unsigned long resource_id, int range_request_id);
121 121
122 gfx::PluginWindowHandle GetPluginWindowHandle(); 122 gfx::PluginWindowHandle GetPluginWindowHandle();
123 123
124 protected: 124 protected:
125 template<class WebPluginDelegateProxy> friend class DeleteTask; 125 template<class WebPluginDelegateProxy> friend class DeleteTask;
126 ~WebPluginDelegateProxy(); 126 virtual ~WebPluginDelegateProxy();
127 127
128 private: 128 private:
129 // Message handlers for messages that proxy WebPlugin methods, which 129 // Message handlers for messages that proxy WebPlugin methods, which
130 // we translate into calls to the real WebPlugin. 130 // we translate into calls to the real WebPlugin.
131 void OnSetWindow(gfx::PluginWindowHandle window); 131 void OnSetWindow(gfx::PluginWindowHandle window);
132 #if defined(OS_WIN) 132 #if defined(OS_WIN)
133 void OnSetWindowlessPumpEvent(HANDLE modal_loop_pump_messages_event); 133 void OnSetWindowlessPumpEvent(HANDLE modal_loop_pump_messages_event);
134 #endif 134 #endif
135 void OnCompleteURL(const std::string& url_in, std::string* url_out, 135 void OnCompleteURL(const std::string& url_in, std::string* url_out,
136 bool* result); 136 bool* result);
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 // This lets us know which portion of the backing store has been painted into. 265 // This lets us know which portion of the backing store has been painted into.
266 gfx::Rect backing_store_painted_; 266 gfx::Rect backing_store_painted_;
267 267
268 // The url of the main frame hosting the plugin. 268 // The url of the main frame hosting the plugin.
269 GURL page_url_; 269 GURL page_url_;
270 270
271 DISALLOW_COPY_AND_ASSIGN(WebPluginDelegateProxy); 271 DISALLOW_COPY_AND_ASSIGN(WebPluginDelegateProxy);
272 }; 272 };
273 273
274 #endif // CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_ 274 #endif // CONTENT_RENDERER_WEBPLUGIN_DELEGATE_PROXY_H_
OLDNEW
« no previous file with comments | « content/renderer/renderer_webidbobjectstore_impl.h ('k') | content/renderer/webworker_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698