chrome/browser/ui/gtk/download/download_item_gtk.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/download/download_item_gtk.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/download/download_item_gtk.h

diff --git a/chrome/browser/ui/gtk/download/download_item_gtk.h b/chrome/browser/ui/gtk/download/download_item_gtk.h

index a8f21b41e5ec88fd47e8ed6ba77784c35c7b3aaf..76f9dc47c7aa5049c1dcda2b43b0b79d6e5cbfe1 100644

--- a/chrome/browser/ui/gtk/download/download_item_gtk.h

+++ b/chrome/browser/ui/gtk/download/download_item_gtk.h

@@ -45,7 +45,7 @@ class DownloadItemGtk : public DownloadItem::Observer,

BaseDownloadItemModel* download_item_model);

// Destroys all widgets belonging to this DownloadItemGtk.

- ~DownloadItemGtk();

+ virtual ~DownloadItemGtk();

// DownloadItem::Observer implementation.

virtual void OnDownloadUpdated(DownloadItem* download);