Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: chrome/browser/history/history.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/file_select_helper.h ('k') | chrome/browser/history/history_notifications.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 559 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 570
571 // Called by TopSites after the thumbnails were read and it is safe 571 // Called by TopSites after the thumbnails were read and it is safe
572 // to delete the thumbnails DB. 572 // to delete the thumbnails DB.
573 void OnTopSitesReady(); 573 void OnTopSitesReady();
574 574
575 // Returns true if this looks like the type of URL we want to add to the 575 // Returns true if this looks like the type of URL we want to add to the
576 // history. We filter out some URLs such as JavaScript. 576 // history. We filter out some URLs such as JavaScript.
577 static bool CanAddURL(const GURL& url); 577 static bool CanAddURL(const GURL& url);
578 578
579 protected: 579 protected:
580 ~HistoryService(); 580 virtual ~HistoryService();
581 581
582 // These are not currently used, hopefully we can do something in the future 582 // These are not currently used, hopefully we can do something in the future
583 // to ensure that the most important things happen first. 583 // to ensure that the most important things happen first.
584 enum SchedulePriority { 584 enum SchedulePriority {
585 PRIORITY_UI, // The highest priority (must respond to UI events). 585 PRIORITY_UI, // The highest priority (must respond to UI events).
586 PRIORITY_NORMAL, // Normal stuff like adding a page. 586 PRIORITY_NORMAL, // Normal stuff like adding a page.
587 PRIORITY_LOW, // Low priority things like indexing or expiration. 587 PRIORITY_LOW, // Low priority things like indexing or expiration.
588 }; 588 };
589 589
590 private: 590 private:
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
867 BookmarkService* bookmark_service_; 867 BookmarkService* bookmark_service_;
868 bool no_db_; 868 bool no_db_;
869 869
870 // True if needs top site migration. 870 // True if needs top site migration.
871 bool needs_top_sites_migration_; 871 bool needs_top_sites_migration_;
872 872
873 DISALLOW_COPY_AND_ASSIGN(HistoryService); 873 DISALLOW_COPY_AND_ASSIGN(HistoryService);
874 }; 874 };
875 875
876 #endif // CHROME_BROWSER_HISTORY_HISTORY_H_ 876 #endif // CHROME_BROWSER_HISTORY_HISTORY_H_
OLDNEW
« no previous file with comments | « chrome/browser/file_select_helper.h ('k') | chrome/browser/history/history_notifications.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698