chrome/browser/history/history.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history.h

diff --git a/chrome/browser/history/history.h b/chrome/browser/history/history.h

index b976c6a7d36ec7b2b2f55b6a9f8ab80aca682582..843148c81a7ef22cf8fe6d20ddd358a9788ff5cd 100644

--- a/chrome/browser/history/history.h

+++ b/chrome/browser/history/history.h

@@ -577,7 +577,7 @@ class HistoryService : public CancelableRequestProvider,

static bool CanAddURL(const GURL& url);

protected:

- ~HistoryService();

+ virtual ~HistoryService();

// These are not currently used, hopefully we can do something in the future

// to ensure that the most important things happen first.

« no previous file with comments | « chrome/browser/file_select_helper.h ('k') | chrome/browser/history/history_notifications.h » ('j') | no next file with comments »