jingle/notifier/base/xmpp_connection.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: jingle/notifier/base/xmpp_connection.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: jingle/notifier/base/xmpp_connection.h

diff --git a/jingle/notifier/base/xmpp_connection.h b/jingle/notifier/base/xmpp_connection.h

index 82520237cb4f9eb0cf661090bd6bc9bcf2fb99f7..e3699cbc25da075a010c188a0b815cbf4ce0d8ce 100644

--- a/jingle/notifier/base/xmpp_connection.h

+++ b/jingle/notifier/base/xmpp_connection.h

@@ -74,7 +74,7 @@ class XmppConnection : public sigslot::has_slots<> {

// Invalidates any weak pointers passed to the delegate by

// OnConnect(), but does not trigger a call to the delegate's

// OnError() function.

- ~XmppConnection();

+ virtual ~XmppConnection();

private:

void OnStateChange(buzz::XmppEngine::State state);

« no previous file with comments | « ipc/ipc_test_sink.h ('k') | media/base/filters.h » ('j') | no next file with comments »