Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: chrome/browser/ui/webui/history2_ui.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_
6 #define CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_ 6 #define CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 14 matching lines...) Expand all
25 25
26 // Called when the network layer has requested a resource underneath 26 // Called when the network layer has requested a resource underneath
27 // the path we registered. 27 // the path we registered.
28 virtual void StartDataRequest(const std::string& path, 28 virtual void StartDataRequest(const std::string& path,
29 bool is_incognito, 29 bool is_incognito,
30 int request_id); 30 int request_id);
31 31
32 virtual std::string GetMimeType(const std::string&) const; 32 virtual std::string GetMimeType(const std::string&) const;
33 33
34 private: 34 private:
35 ~HistoryUIHTMLSource2() {} 35 virtual ~HistoryUIHTMLSource2() {}
36 36
37 DISALLOW_COPY_AND_ASSIGN(HistoryUIHTMLSource2); 37 DISALLOW_COPY_AND_ASSIGN(HistoryUIHTMLSource2);
38 }; 38 };
39 39
40 // The handler for Javascript messages related to the "history" view. 40 // The handler for Javascript messages related to the "history" view.
41 class BrowsingHistoryHandler2 : public WebUIMessageHandler { 41 class BrowsingHistoryHandler2 : public WebUIMessageHandler {
42 public: 42 public:
43 BrowsingHistoryHandler2(); 43 BrowsingHistoryHandler2();
44 virtual ~BrowsingHistoryHandler2(); 44 virtual ~BrowsingHistoryHandler2();
45 45
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 // Return the URL for a given search term. 94 // Return the URL for a given search term.
95 static const GURL GetHistoryURLWithSearchText(const string16& text); 95 static const GURL GetHistoryURLWithSearchText(const string16& text);
96 96
97 static RefCountedMemory* GetFaviconResourceBytes(); 97 static RefCountedMemory* GetFaviconResourceBytes();
98 98
99 private: 99 private:
100 DISALLOW_COPY_AND_ASSIGN(HistoryUI2); 100 DISALLOW_COPY_AND_ASSIGN(HistoryUI2);
101 }; 101 };
102 102
103 #endif // CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_ 103 #endif // CHROME_BROWSER_UI_WEBUI_HISTORY2_UI_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/tab_contents/tab_contents_wrapper.h ('k') | chrome/browser/ui/webui/keyboard_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698