chrome/browser/ui/gtk/custom_button.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/custom_button.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/custom_button.h

diff --git a/chrome/browser/ui/gtk/custom_button.h b/chrome/browser/ui/gtk/custom_button.h

index eb0dbe806127ddcd2d5fb01f66275946240208e8..6bb3c1f6dc449f22693707420161443824df6e82 100644

--- a/chrome/browser/ui/gtk/custom_button.h

+++ b/chrome/browser/ui/gtk/custom_button.h

@@ -38,7 +38,7 @@ class CustomDrawButtonBase : public NotificationObserver {

int hover_id,

int disabled_id);

- ~CustomDrawButtonBase();

+ virtual ~CustomDrawButtonBase();

// Flip the image horizontally. Not to be used for RTL/LTR reasons. (In RTL

// mode, this will unflip the image.)

@@ -154,7 +154,7 @@ class CustomDrawButton : public NotificationObserver {

int disabled_id,

GtkWidget* native_widget);

- ~CustomDrawButton();

+ virtual ~CustomDrawButton();

void Init();