Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: content/browser/plugin_service.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This class responds to requests from renderers for the list of plugins, and 5 // This class responds to requests from renderers for the list of plugins, and
6 // also a proxy object for plugin instances. 6 // also a proxy object for plugin instances.
7 7
8 #ifndef CONTENT_BROWSER_PLUGIN_SERVICE_H_ 8 #ifndef CONTENT_BROWSER_PLUGIN_SERVICE_H_
9 #define CONTENT_BROWSER_PLUGIN_SERVICE_H_ 9 #define CONTENT_BROWSER_PLUGIN_SERVICE_H_
10 #pragma once 10 #pragma once
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // list, and optionally also reload all the pages with plugins. 117 // list, and optionally also reload all the pages with plugins.
118 // NOTE: can only be called on the UI thread. 118 // NOTE: can only be called on the UI thread.
119 static void PurgePluginListCache(bool reload_pages); 119 static void PurgePluginListCache(bool reload_pages);
120 120
121 private: 121 private:
122 friend struct DefaultSingletonTraits<PluginService>; 122 friend struct DefaultSingletonTraits<PluginService>;
123 123
124 // Creates the PluginService object, but doesn't actually build the plugin 124 // Creates the PluginService object, but doesn't actually build the plugin
125 // list yet. It's generated lazily. 125 // list yet. It's generated lazily.
126 PluginService(); 126 PluginService();
127 ~PluginService(); 127 virtual ~PluginService();
128 128
129 // base::WaitableEventWatcher::Delegate implementation. 129 // base::WaitableEventWatcher::Delegate implementation.
130 virtual void OnWaitableEventSignaled(base::WaitableEvent* waitable_event); 130 virtual void OnWaitableEventSignaled(base::WaitableEvent* waitable_event);
131 131
132 // NotificationObserver implementation 132 // NotificationObserver implementation
133 virtual void Observe(NotificationType type, const NotificationSource& source, 133 virtual void Observe(NotificationType type, const NotificationSource& source,
134 const NotificationDetails& details); 134 const NotificationDetails& details);
135 135
136 void RegisterPepperPlugins(); 136 void RegisterPepperPlugins();
137 137
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 188
189 std::vector<OverriddenPlugin> overridden_plugins_; 189 std::vector<OverriddenPlugin> overridden_plugins_;
190 base::Lock overridden_plugins_lock_; 190 base::Lock overridden_plugins_lock_;
191 191
192 DISALLOW_COPY_AND_ASSIGN(PluginService); 192 DISALLOW_COPY_AND_ASSIGN(PluginService);
193 }; 193 };
194 194
195 DISABLE_RUNNABLE_METHOD_REFCOUNT(PluginService); 195 DISABLE_RUNNABLE_METHOD_REFCOUNT(PluginService);
196 196
197 #endif // CONTENT_BROWSER_PLUGIN_SERVICE_H_ 197 #endif // CONTENT_BROWSER_PLUGIN_SERVICE_H_
OLDNEW
« no previous file with comments | « content/browser/mock_resource_context.h ('k') | content/browser/renderer_host/blob_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698