Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1764)

Unified Diff: net/url_request/url_request_simple_job.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_error_job.h ('k') | printing/printing_context_cairo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_simple_job.h
diff --git a/net/url_request/url_request_simple_job.h b/net/url_request/url_request_simple_job.h
index 879319c44fe44d1e096daeba67b339f1f8ba936e..8ba910412a978071083820205c4d7433f4bbbbf0 100644
--- a/net/url_request/url_request_simple_job.h
+++ b/net/url_request/url_request_simple_job.h
@@ -25,7 +25,7 @@ class URLRequestSimpleJob : public URLRequestJob {
virtual bool GetCharset(std::string* charset);
protected:
- ~URLRequestSimpleJob();
+ virtual ~URLRequestSimpleJob();
// subclasses must override the way response data is determined.
virtual bool GetData(std::string* mime_type,
« no previous file with comments | « net/url_request/url_request_error_job.h ('k') | printing/printing_context_cairo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698