net/url_request/url_request_simple_job.h - Issue 7064033: Virtual destructors should have virtual keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_simple_job.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_simple_job.h

diff --git a/net/url_request/url_request_simple_job.h b/net/url_request/url_request_simple_job.h

index 879319c44fe44d1e096daeba67b339f1f8ba936e..8ba910412a978071083820205c4d7433f4bbbbf0 100644

--- a/net/url_request/url_request_simple_job.h

+++ b/net/url_request/url_request_simple_job.h

@@ -25,7 +25,7 @@ class URLRequestSimpleJob : public URLRequestJob {

virtual bool GetCharset(std::string* charset);

protected:

- ~URLRequestSimpleJob();

+ virtual ~URLRequestSimpleJob();

// subclasses must override the way response data is determined.

virtual bool GetData(std::string* mime_type,

« no previous file with comments | « net/url_request/url_request_error_job.h ('k') | printing/printing_context_cairo.h » ('j') | no next file with comments »