Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/browser/nacl_host/nacl_process_host.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/mach_broker_mac.h ('k') | chrome/browser/net/chrome_net_log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_ 5 #ifndef CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
6 #define CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_ 6 #define CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
7 #pragma once 7 #pragma once
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
11 #include "base/file_path.h" 11 #include "base/file_path.h"
12 #include "base/file_util_proxy.h" 12 #include "base/file_util_proxy.h"
13 #include "base/memory/ref_counted.h" 13 #include "base/memory/ref_counted.h"
14 #include "base/memory/scoped_callback_factory.h" 14 #include "base/memory/scoped_callback_factory.h"
15 #include "chrome/common/nacl_types.h" 15 #include "chrome/common/nacl_types.h"
16 #include "content/browser/browser_child_process_host.h" 16 #include "content/browser/browser_child_process_host.h"
17 17
18 class ChromeRenderMessageFilter; 18 class ChromeRenderMessageFilter;
19 19
20 // Represents the browser side of the browser <--> NaCl communication 20 // Represents the browser side of the browser <--> NaCl communication
21 // channel. There will be one NaClProcessHost per NaCl process 21 // channel. There will be one NaClProcessHost per NaCl process
22 // The browser is responsible for starting the NaCl process 22 // The browser is responsible for starting the NaCl process
23 // when requested by the renderer. 23 // when requested by the renderer.
24 // After that, most of the communication is directly between NaCl plugin 24 // After that, most of the communication is directly between NaCl plugin
25 // running in the renderer and NaCl processes. 25 // running in the renderer and NaCl processes.
26 class NaClProcessHost : public BrowserChildProcessHost { 26 class NaClProcessHost : public BrowserChildProcessHost {
27 public: 27 public:
28 explicit NaClProcessHost(const std::wstring& url); 28 explicit NaClProcessHost(const std::wstring& url);
29 ~NaClProcessHost(); 29 virtual ~NaClProcessHost();
30 30
31 // Initialize the new NaCl process, returning true on success. 31 // Initialize the new NaCl process, returning true on success.
32 bool Launch(ChromeRenderMessageFilter* chrome_render_message_filter, 32 bool Launch(ChromeRenderMessageFilter* chrome_render_message_filter,
33 int socket_count, 33 int socket_count,
34 IPC::Message* reply_msg); 34 IPC::Message* reply_msg);
35 35
36 virtual bool OnMessageReceived(const IPC::Message& msg); 36 virtual bool OnMessageReceived(const IPC::Message& msg);
37 37
38 void OnProcessLaunchedByBroker(base::ProcessHandle handle); 38 void OnProcessLaunchedByBroker(base::ProcessHandle handle);
39 39
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // Windows platform flag 76 // Windows platform flag
77 bool running_on_wow64_; 77 bool running_on_wow64_;
78 78
79 base::ScopedCallbackFactory<NaClProcessHost> callback_factory_; 79 base::ScopedCallbackFactory<NaClProcessHost> callback_factory_;
80 80
81 DISALLOW_COPY_AND_ASSIGN(NaClProcessHost); 81 DISALLOW_COPY_AND_ASSIGN(NaClProcessHost);
82 }; 82 };
83 83
84 #endif // CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_ 84 #endif // CHROME_BROWSER_NACL_HOST_NACL_PROCESS_HOST_H_
OLDNEW
« no previous file with comments | « chrome/browser/mach_broker_mac.h ('k') | chrome/browser/net/chrome_net_log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698