Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Side by Side Diff: net/http/http_auth_handler_basic.h

Issue 7064033: Virtual destructors should have virtual keyword. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/ftp/ftp_network_layer.h ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 5 #ifndef NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
6 #define NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 6 #define NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 27 matching lines...) Expand all
38 protected: 38 protected:
39 virtual bool Init(HttpAuth::ChallengeTokenizer* challenge); 39 virtual bool Init(HttpAuth::ChallengeTokenizer* challenge);
40 40
41 virtual int GenerateAuthTokenImpl(const string16* username, 41 virtual int GenerateAuthTokenImpl(const string16* username,
42 const string16* password, 42 const string16* password,
43 const HttpRequestInfo* request, 43 const HttpRequestInfo* request,
44 CompletionCallback* callback, 44 CompletionCallback* callback,
45 std::string* auth_token); 45 std::string* auth_token);
46 46
47 private: 47 private:
48 ~HttpAuthHandlerBasic() {} 48 virtual ~HttpAuthHandlerBasic() {}
49 49
50 bool ParseChallenge(HttpAuth::ChallengeTokenizer* challenge); 50 bool ParseChallenge(HttpAuth::ChallengeTokenizer* challenge);
51 }; 51 };
52 52
53 } // namespace net 53 } // namespace net
54 54
55 #endif // NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_ 55 #endif // NET_HTTP_HTTP_AUTH_HANDLER_BASIC_H_
OLDNEW
« no previous file with comments | « net/ftp/ftp_network_layer.h ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698