Have test_content_client look for .pak file in the .apk as well as on disk

Have test_content_client look for .pak file in the .apk as well as on disk

Most tests use .isolate files to put files on disk, but
webkit_unit_tests (maybe others?) don't.

BUG=505538
Committed: https://crrev.com/caa7a3dddb27b19ebaddd5a2ada5f33be3f1e799
Cr-Commit-Position: refs/heads/master@{#336644}

[agrieve, 2015-06-29 19:58:08]

agrieve@chromium.org changed reviewers:
+ jcivelli@chromium.org

[agrieve, 2015-06-29 20:17:39]

agrieve@chromium.org changed reviewers:
+ sievers@chromium.org

[agrieve, 2015-06-29 20:18:25]

agrieve@chromium.org changed reviewers:
- sievers@chromium.org

[Jay Civelli, 2015-06-29 20:20:20]

lgtm

[boliu, 2015-06-29 20:24:32]

boliu@chromium.org changed reviewers:
+ boliu@chromium.org

[boliu, 2015-06-29 20:24:32]

Probably important enough to tbr..

https://codereview.chromium.org/1217063002/diff/1/content/test/test_content_c...
File content/test/test_content_client.cc (right):

https://codereview.chromium.org/1217063002/diff/1/content/test/test_content_c...
content/test/test_content_client.cc:30: return;
This is making the structure here super brittle. Eg someone could add something
else at the end of the constructor and totally miss the early out here.

How about instead of having a common base::FilePath, have a common base::File +
Region that's passed to LoadFromFileRegion at the end?

There's Region::kWholeFile that should work for other platforms.

[boliu, 2015-06-29 20:25:03]

On 2015/06/29 20:24:32, boliu wrote:
> Probably important enough to tbr..

Oh, ha!

[agrieve, 2015-06-29 20:38:04]

https://codereview.chromium.org/1217063002/diff/1/content/test/test_content_c...
File content/test/test_content_client.cc (right):

https://codereview.chromium.org/1217063002/diff/1/content/test/test_content_c...
content/test/test_content_client.cc:30: return;
On 2015/06/29 20:24:32, boliu wrote:
> This is making the structure here super brittle. Eg someone could add
something
> else at the end of the constructor and totally miss the early out here.
> 
> How about instead of having a common base::FilePath, have a common base::File
+
> Region that's passed to LoadFromFileRegion at the end?
> 
> There's Region::kWholeFile that should work for other platforms.

Agree. Will address in a follow-up.

[agrieve, 2015-06-29 20:38:09]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-06-29 20:41:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1217063002/1

[commit-bot: I haz the power, 2015-06-29 21:20:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-29 21:21:21]

Patchset 1 (id:??) landed as
https://crrev.com/caa7a3dddb27b19ebaddd5a2ada5f33be3f1e799
Cr-Commit-Position: refs/heads/master@{#336644}