Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1363423002: GN: Don't automatically grant permissions when installing incremental apks (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't automatically grant permissions when installing incremental apks BUG=520082 Committed: https://crrev.com/2087f15fb276483dcc40e97c7d1a4813f689f7a2 Cr-Commit-Position: refs/heads/master@{#350690}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/android/incremental_install/installer.py View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
PTaL
5 years, 3 months ago (2015-09-24 19:45:05 UTC) #2
pkotwicz
lgtm
5 years, 3 months ago (2015-09-24 21:00:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363423002/1
5 years, 3 months ago (2015-09-24 21:57:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-24 23:09:15 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 23:09:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2087f15fb276483dcc40e97c7d1a4813f689f7a2
Cr-Commit-Position: refs/heads/master@{#350690}

Powered by Google App Engine
This is Rietveld 408576698