Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1236643002: GN: Fix input not defined by deps issue with //build/android:sun_tools_java (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix input not defined by deps issue with //build/android:sun_tools_java BUG= Committed: https://crrev.com/0004c4777790d38df47621342790500788d1623b Cr-Commit-Position: refs/heads/master@{#338428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M build/android/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +6 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 5 months ago (2015-07-10 17:15:59 UTC) #2
cjhopman
lgtm
5 years, 5 months ago (2015-07-10 22:49:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236643002/1
5 years, 5 months ago (2015-07-11 01:58:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-11 02:51:47 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 02:52:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0004c4777790d38df47621342790500788d1623b
Cr-Commit-Position: refs/heads/master@{#338428}

Powered by Google App Engine
This is Rietveld 408576698