Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1317853006: GN: Make the wrapper script generated for junit work without extra args (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make the wrapper script generated for junit work without extra args Still works with GYP, but for gyp you need the extra arg. BUG= Committed: https://crrev.com/60d3387b05d03cccc8b2339a0541ef6972d2a307 Cr-Commit-Position: refs/heads/master@{#347413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -7 lines) Patch
M build/android/gyp/create_java_binary_script.py View 4 chunks +5 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 3 chunks +16 lines, -1 line 0 comments Download
M build/config/android/rules.gni View 2 chunks +8 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 3 months ago (2015-09-04 00:37:08 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-04 00:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317853006/1
5 years, 3 months ago (2015-09-04 13:56:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 15:40:16 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 15:41:10 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60d3387b05d03cccc8b2339a0541ef6972d2a307
Cr-Commit-Position: refs/heads/master@{#347413}

Powered by Google App Engine
This is Rietveld 408576698