Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1389663002: GN: Add --depfile to generate_incremental_manifest.py action. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add --depfile to generate_incremental_manifest.py action. Fixes the target always being considered dirty BUG= Committed: https://crrev.com/5a3bf6ce59ee0d9b37c935d7166aacb9feec8cc9 Cr-Commit-Position: refs/heads/master@{#352399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389663002/1
5 years, 2 months ago (2015-10-05 14:47:34 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/78110)
5 years, 2 months ago (2015-10-05 14:55:57 UTC) #5
agrieve
On 2015/10/05 14:55:57, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
5 years, 2 months ago (2015-10-05 15:01:35 UTC) #6
pkotwicz
lgtm
5 years, 2 months ago (2015-10-05 19:48:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389663002/1
5 years, 2 months ago (2015-10-05 19:54:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 20:13:28 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 20:15:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a3bf6ce59ee0d9b37c935d7166aacb9feec8cc9
Cr-Commit-Position: refs/heads/master@{#352399}

Powered by Google App Engine
This is Rietveld 408576698