Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1406423007: GN(Android): Fix up content_gl_tests to match GYP (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(Android): Fix up content_gl_tests to match GYP BUG=510485 Committed: https://crrev.com/a48927a7656aa8ae959ed5a98b53768db7ddd104 Cr-Commit-Position: refs/heads/master@{#356889}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/content_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (3 generated)
agrieve
5 years, 2 months ago (2015-10-22 19:53:38 UTC) #2
pkotwicz
Can you please merge with https://codereview.chromium.org/1417873003/
5 years, 2 months ago (2015-10-22 22:30:39 UTC) #3
agrieve
On 2015/10/22 22:30:39, pkotwicz wrote: > Can you please merge with https://codereview.chromium.org/1417873003/ Merged an updated ...
5 years, 2 months ago (2015-10-23 15:49:41 UTC) #5
brettw
lgtm
5 years, 1 month ago (2015-10-26 00:29:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1406423007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1406423007/20001
5 years, 1 month ago (2015-10-29 16:04:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 18:12:45 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 18:13:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a48927a7656aa8ae959ed5a98b53768db7ddd104
Cr-Commit-Position: refs/heads/master@{#356889}

Powered by Google App Engine
This is Rietveld 408576698