Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334303003: DeviceUtils: When skipping "adb install", run "am force-stop" (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils: When skipping "adb install", run "am force-stop" An "adb install" always terminates the app, so when skipping the step, we should terminate the app to have consistent behaviour. BUG= Committed: https://crrev.com/a87495be3a6a5be1ac0d1175898efa54689a99ff Cr-Commit-Position: refs/heads/master@{#348712}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use existing ForceStop() #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/android/devil/android/device_utils.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 11 (3 generated)
agrieve
5 years, 3 months ago (2015-09-11 15:30:59 UTC) #2
jbudorick
https://codereview.chromium.org/1334303003/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1334303003/diff/1/build/android/devil/android/device_utils.py#newcode982 build/android/devil/android/device_utils.py:982: def ForceStop(self, package, timeout=None, retries=None): Use this instead of ...
5 years, 3 months ago (2015-09-11 15:33:05 UTC) #3
agrieve
https://codereview.chromium.org/1334303003/diff/1/build/android/devil/android/device_utils.py File build/android/devil/android/device_utils.py (right): https://codereview.chromium.org/1334303003/diff/1/build/android/devil/android/device_utils.py#newcode982 build/android/devil/android/device_utils.py:982: def ForceStop(self, package, timeout=None, retries=None): On 2015/09/11 15:33:05, jbudorick ...
5 years, 3 months ago (2015-09-11 15:51:04 UTC) #4
jbudorick
lgtm, though I think this conflicts with your _InstallInternal rewrite
5 years, 3 months ago (2015-09-14 17:49:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334303003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334303003/40001
5 years, 3 months ago (2015-09-14 19:09:08 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 20:35:09 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a87495be3a6a5be1ac0d1175898efa54689a99ff Cr-Commit-Position: refs/heads/master@{#348712}
5 years, 3 months ago (2015-09-14 20:35:59 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:59 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a87495be3a6a5be1ac0d1175898efa54689a99ff
Cr-Commit-Position: refs/heads/master@{#348712}

Powered by Google App Engine
This is Rietveld 408576698