Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1398613002: DeviceUtils.ForceStop: no-op if the app isn't running (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils.ForceStop: no-op if the app isn't running am force-stop takes > 1 second, so it's worth checking the app is even running first. BUG=540857 Committed: https://crrev.com/491f8007366e6505f46e98cef46283b366637202 Cr-Commit-Position: refs/heads/master@{#353876}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/android/devil/android/device_utils.py View 1 1 chunk +2 lines, -1 line 0 comments Download
M build/android/devil/android/device_utils_test.py View 1 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (7 generated)
agrieve
On 2015/10/08 01:15:15, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org
5 years, 2 months ago (2015-10-08 01:15:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398613002/1
5 years, 2 months ago (2015-10-08 01:15:33 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 04:21:31 UTC) #6
jbudorick
lgtm pending the resolution of the RunShellCommand shell variables comment in the other review.
5 years, 2 months ago (2015-10-08 14:36:46 UTC) #7
agrieve
On 2015/10/08 14:36:46, jbudorick wrote: > lgtm pending the resolution of the RunShellCommand shell variables ...
5 years, 2 months ago (2015-10-08 15:46:06 UTC) #8
agrieve
On 2015/10/08 15:46:06, agrieve wrote: > On 2015/10/08 14:36:46, jbudorick wrote: > > lgtm pending ...
5 years, 2 months ago (2015-10-09 18:11:58 UTC) #9
jbudorick
On 2015/10/09 18:11:58, agrieve wrote: > On 2015/10/08 15:46:06, agrieve wrote: > > On 2015/10/08 ...
5 years, 2 months ago (2015-10-12 13:04:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398613002/1
5 years, 2 months ago (2015-10-13 15:18:39 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/80625) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-13 15:24:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398613002/20001
5 years, 2 months ago (2015-10-13 19:41:58 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-13 22:25:16 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-13 22:26:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/491f8007366e6505f46e98cef46283b366637202
Cr-Commit-Position: refs/heads/master@{#353876}

Powered by Google App Engine
This is Rietveld 408576698