Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1233453010: GN: Fix support errorprone and java_binary (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman, brettw
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, raywilliams_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn12
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix support errorprone and java_binary Also adds errorprone to the default set of targets. BUG=509156 Committed: https://crrev.com/40ba686a6a6cd4387759376bebe505298742ca50 Cr-Commit-Position: refs/heads/master@{#338803}

Patch Set 1 #

Patch Set 2 : Add errorprone target only for OS=android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/BUILD.gn View 1 1 chunk +1 line, -3 lines 0 comments Download
M build/android/gyp/javac.py View 1 chunk +5 lines, -3 lines 0 comments Download
M build/config/android/internal_rules.gni View 8 chunks +17 lines, -7 lines 0 comments Download
M build/config/android/rules.gni View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/errorprone/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
agrieve
cjhopman@chromium.org: Please review changes in everything brettw@chromium.org: Please review changes in /BUILD.gn
5 years, 5 months ago (2015-07-11 02:19:54 UTC) #2
brettw
toplevel BUILD.gn lgtm
5 years, 5 months ago (2015-07-11 17:14:02 UTC) #3
cjhopman
lgtm
5 years, 5 months ago (2015-07-14 18:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233453010/1
5 years, 5 months ago (2015-07-14 18:28:14 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/57613) linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-14 18:35:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233453010/20001
5 years, 5 months ago (2015-07-15 00:45:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-15 02:09:24 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 02:11:04 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40ba686a6a6cd4387759376bebe505298742ca50
Cr-Commit-Position: refs/heads/master@{#338803}

Powered by Google App Engine
This is Rietveld 408576698