Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1352043007: GN: Make _incremental apk targets work when no <application> exists (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Make _incremental apk targets work when no <application> exists BUG=534849 Committed: https://crrev.com/74be507bf420d21eed1a354dc15b4784a6aba4ff Cr-Commit-Position: refs/heads/master@{#350236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M build/android/incremental_install/generate_android_manifest.py View 4 chunks +7 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 8 (3 generated)
kjellander_chromium
lgtm. Thanks!
5 years, 3 months ago (2015-09-22 19:58:22 UTC) #3
pkotwicz
lgtm
5 years, 3 months ago (2015-09-22 19:59:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352043007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352043007/1
5 years, 3 months ago (2015-09-22 20:00:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-22 21:27:07 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 21:53:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/74be507bf420d21eed1a354dc15b4784a6aba4ff
Cr-Commit-Position: refs/heads/master@{#350236}

Powered by Google App Engine
This is Rietveld 408576698