Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1395013002: GN: Fix incremental install failing on some 64 bit devices (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix incremental install failing on some 64 bit devices Nexus 9 complained of libraries being 32-bit instead of 64-bit without the placeholder kicking it into 32-bit mode. BUG=384638 Committed: https://crrev.com/8e18e37a3b8a95b2068a5f552e748981cfe97106 Cr-Commit-Position: refs/heads/master@{#353205}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M build/android/gyp/apkbuilder.py View 3 chunks +10 lines, -1 line 1 comment Download
M build/config/android/internal_rules.gni View 4 chunks +16 lines, -5 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
agrieve
On 2015/10/08 23:53:40, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:newt@chromium.org ☜☞
5 years, 2 months ago (2015-10-08 23:54:19 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/1395013002/diff/1/build/android/gyp/apkbuilder.py File build/android/gyp/apkbuilder.py (right): https://codereview.chromium.org/1395013002/diff/1/build/android/gyp/apkbuilder.py#newcode78 build/android/gyp/apkbuilder.py:78: apk.writestr('lib/%s/libplaceholder.so' % options.android_abi, ':-)') Nice :-)
5 years, 2 months ago (2015-10-09 00:00:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395013002/1
5 years, 2 months ago (2015-10-09 00:16:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 01:22:48 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 01:24:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e18e37a3b8a95b2068a5f552e748981cfe97106
Cr-Commit-Position: refs/heads/master@{#353205}

Powered by Google App Engine
This is Rietveld 408576698