Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1388373003: DeviceUtils.Install: Don't re-grant perms when apk hasn't changed. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, rnpehew_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DeviceUtils.Install: Don't re-grant perms when apk hasn't changed. Permission granting is between 1-2 seconds, so saves some time when running unit tests. BUG=540857 Committed: https://crrev.com/d88c093b6c403276e864bbf063ed2d040486d31d Cr-Commit-Position: refs/heads/master@{#353060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/android/devil/android/device_utils.py View 2 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
On 2015/10/08 00:53:01, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org another possibility for ...
5 years, 2 months ago (2015-10-08 00:55:13 UTC) #2
jbudorick
lgtm +rnephew IIRC we looked at install -g and opted to grant the permissions requested ...
5 years, 2 months ago (2015-10-08 00:58:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388373003/1
5 years, 2 months ago (2015-10-08 01:15:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-08 02:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388373003/1
5 years, 2 months ago (2015-10-08 15:34:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-08 15:41:27 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-08 15:42:04 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d88c093b6c403276e864bbf063ed2d040486d31d
Cr-Commit-Position: refs/heads/master@{#353060}

Powered by Google App Engine
This is Rietveld 408576698