Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1354153004: GN: Don't build final_dex when building *_incremental targets (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't build final_dex when building *_incremental targets The final dex is not required and slow to build. BUG=533442 Committed: https://crrev.com/3bd8449dd562b934d6f0158546d5be9fc25d371c Cr-Commit-Position: refs/heads/master@{#350373}

Patch Set 1 #

Patch Set 2 : split up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/config/android/internal_rules.gni View 4 chunks +8 lines, -3 lines 0 comments Download
M build/config/android/rules.gni View 1 2 chunks +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
pkotwicz
From offline discussion: We are unsure whether the "create_dist_target" is needed when running tests with ...
5 years, 3 months ago (2015-09-21 19:49:24 UTC) #2
agrieve
On 2015/09/21 19:49:24, pkotwicz wrote: > From offline discussion: > We are unsure whether the ...
5 years, 3 months ago (2015-09-23 18:02:12 UTC) #3
pkotwicz
lgtm
5 years, 3 months ago (2015-09-23 18:13:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354153004/20001
5 years, 3 months ago (2015-09-23 18:34:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/117349)
5 years, 3 months ago (2015-09-23 20:25:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1354153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1354153004/20001
5 years, 3 months ago (2015-09-23 20:36:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-23 22:09:38 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 22:10:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bd8449dd562b934d6f0158546d5be9fc25d371c
Cr-Commit-Position: refs/heads/master@{#350373}

Powered by Google App Engine
This is Rietveld 408576698