GN: Fix up net_unittests to match GYP

GN(Android): Fix up net_unittests to match GYP

BUG=510485
Committed: https://crrev.com/a5517aadb066dc14bf4c5a961f6f873321e05595
Cr-Commit-Position: refs/heads/master@{#355716}

[agrieve, 2015-10-22 13:42:31]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org, pkotwicz@chromium.org

[agrieve, 2015-10-22 15:18:12]

Description was changed from

==========
GN: Fix up net_unittests to match GYP

BUG=510485
==========

to

==========
GN(Android): Fix up net_unittests to match GYP

BUG=510485
==========

[pkotwicz, 2015-10-22 17:39:16]

https://codereview.chromium.org/1423633002/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/20001/net/BUILD.gn#newcode1206
net/BUILD.gn:1206: _net_unittests_apk_assets_dir =
"$root_build_dir/net_unittests_apk/assets"
Nit: root_out_dir here too?

https://codereview.chromium.org/1423633002/diff/20001/net/android/BUILD.gn
File net/android/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/20001/net/android/BUILD.gn#ne...
net/android/BUILD.gn:41: custom_package = "org.chromium.net.tests"
Does it matter what the custom package name is? If it's not can you use the
default package name (org.chromium.native_test I think?)

[agrieve, 2015-10-22 19:56:26]

https://codereview.chromium.org/1423633002/diff/20001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/20001/net/BUILD.gn#newcode1206
net/BUILD.gn:1206: _net_unittests_apk_assets_dir =
"$root_build_dir/net_unittests_apk/assets"
On 2015/10/22 17:39:16, pkotwicz wrote:
> Nit: root_out_dir here too?

Done.

https://codereview.chromium.org/1423633002/diff/20001/net/android/BUILD.gn
File net/android/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/20001/net/android/BUILD.gn#ne...
net/android/BUILD.gn:41: custom_package = "org.chromium.net.tests"
On 2015/10/22 17:39:16, pkotwicz wrote:
> Does it matter what the custom package name is? If it's not can you use the
> default package name (org.chromium.native_test I think?)

Doesn't matter. set to org.chromium.native_test

[pkotwicz, 2015-10-22 21:37:16]

lgtm

[brettw, 2015-10-22 23:57:19]

lgtm

https://codereview.chromium.org/1423633002/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/40001/net/BUILD.gn#newcode1206
net/BUILD.gn:1206: _net_unittests_apk_assets_dir =
"$root_out_dir/net_unittests_apk/assets"
Why bother with this intermediate variable? I'd just assign
  dest = "$root_out..." 
below.

[agrieve, 2015-10-23 02:24:16]

https://codereview.chromium.org/1423633002/diff/40001/net/BUILD.gn
File net/BUILD.gn (right):

https://codereview.chromium.org/1423633002/diff/40001/net/BUILD.gn#newcode1206
net/BUILD.gn:1206: _net_unittests_apk_assets_dir =
"$root_out_dir/net_unittests_apk/assets"
On 2015/10/22 23:57:19, brettw wrote:
> Why bother with this intermediate variable? I'd just assign
>   dest = "$root_out..." 
> below.

Because it's used again below: 

apk_asset_location = _net_unittests_apk_assets_dir

Had a quick brainstorm with Peter today though, and plan to re-work how Android
APK assets are specified in GN to be more like android_resources().

[agrieve, 2015-10-23 02:24:25]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-10-23 02:24:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423633002/40001

[commit-bot: I haz the power, 2015-10-23 03:03:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 03:04:42]

Patchset 3 (id:??) landed as
https://crrev.com/a5517aadb066dc14bf4c5a961f6f873321e05595
Cr-Commit-Position: refs/heads/master@{#355716}