GN Incremental Install: Don't use proguarded dex when is_debug = false

GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
Committed: https://crrev.com/f62854810a390c41afcdde391b3aa0f56a9b367a
Cr-Commit-Position: refs/heads/master@{#361762}

[agrieve, 2015-11-24 20:44:19]

Description was changed from

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
==========

to

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
==========

[agrieve, 2015-11-24 20:44:19]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2015-11-24 20:44:37]

On 2015/11/24 20:44:19, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:yfriedman@chromium.org

™

[Yaron, 2015-11-24 22:42:06]

hmm. this seems a little unintuitive...

I'm building in release mode but not getting proguarded code? Could we either:
a) output a log that you're doing something screwy and buyer beware
or 
b) have it fail at gn time and indicate that you need to explicitly disable
proguard?

[agrieve, 2015-11-25 18:31:03]

On 2015/11/24 22:42:06, Yaron wrote:
> hmm. this seems a little unintuitive...
> 
> I'm building in release mode but not getting proguarded code? Could we either:
> a) output a log that you're doing something screwy and buyer beware
> or 
> b) have it fail at gn time and indicate that you need to explicitly disable
> proguard?

Added a warning upon install

[Yaron, 2015-11-25 19:10:10]

lgtm

[agrieve, 2015-11-25 19:53:12]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-11-25 19:55:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471393002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471393002/20001

[commit-bot: I haz the power, 2015-11-26 00:33:22]

Description was changed from

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
==========

to

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
==========

[commit-bot: I haz the power, 2015-11-26 00:33:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-26 00:34:48]

Description was changed from

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306
==========

to

==========
GN Incremental Install: Don't use proguarded dex when is_debug = false

Release mode is often used to test native code performance, and so
incremental install is useful with is_debug = false. When proguard is
enabled however, incremental are currently broken.

This change forces _incremental targets to use non-proguarded .dex files
even when is_debug = false.

It also fixes the install step when only a single dex file exists.

BUG=559306

Committed: https://crrev.com/f62854810a390c41afcdde391b3aa0f56a9b367a
Cr-Commit-Position: refs/heads/master@{#361762}
==========

[commit-bot: I haz the power, 2015-11-26 00:34:48]

Patchset 2 (id:??) landed as
https://crrev.com/f62854810a390c41afcdde391b3aa0f56a9b367a
Cr-Commit-Position: refs/heads/master@{#361762}