Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371373003: Set an empty sourcepath when compiling java. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set an empty sourcepath when compiling java. Nice explanation of why this is a good idea: http://blog.ltgt.net/most-build-tools-misuse-javac/ BUG=536817 Committed: https://crrev.com/561071cb20dba8201f8ad6846578fdb35a9f2d3e Cr-Commit-Position: refs/heads/master@{#351361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/android/gyp/javac.py View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1371403002 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 2 months ago (2015-09-29 13:44:18 UTC) #2
Yaron
lgtm
5 years, 2 months ago (2015-09-29 16:53:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371373003/1
5 years, 2 months ago (2015-09-29 17:21:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 18:35:38 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 18:38:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/561071cb20dba8201f8ad6846578fdb35a9f2d3e
Cr-Commit-Position: refs/heads/master@{#351361}

Powered by Google App Engine
This is Rietveld 408576698