Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1326)

Issue 1384673004: GN: Fix Chrome crashing on start-up (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix Chrome crashing on start-up Reason: libc++ must be the first one listed in libs setting. Broke in http://crrev.com/a43e85a1b BUG=537313 Committed: https://crrev.com/46c4fe530f88184f74bb4b2fc5f777d2d112d6bd Cr-Commit-Position: refs/heads/master@{#352099}

Patch Set 1 #

Total comments: 2

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/config/android/BUILD.gn View 1 1 chunk +8 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
agrieve
On 2015/10/02 18:07:16, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:brettw@chromium.org
5 years, 2 months ago (2015-10-02 18:09:33 UTC) #2
brettw
lgtm https://codereview.chromium.org/1384673004/diff/1/build/config/android/BUILD.gn File build/config/android/BUILD.gn (right): https://codereview.chromium.org/1384673004/diff/1/build/config/android/BUILD.gn#newcode155 build/config/android/BUILD.gn:155: libs = [ I'd prefer to have this ...
5 years, 2 months ago (2015-10-02 18:13:17 UTC) #3
agrieve
https://codereview.chromium.org/1384673004/diff/1/build/config/android/BUILD.gn File build/config/android/BUILD.gn (right): https://codereview.chromium.org/1384673004/diff/1/build/config/android/BUILD.gn#newcode155 build/config/android/BUILD.gn:155: libs = [ On 2015/10/02 18:13:16, brettw wrote: > ...
5 years, 2 months ago (2015-10-02 18:16:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384673004/20001
5 years, 2 months ago (2015-10-02 18:17:19 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-02 19:15:42 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 19:16:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46c4fe530f88184f74bb4b2fc5f777d2d112d6bd
Cr-Commit-Position: refs/heads/master@{#352099}

Powered by Google App Engine
This is Rietveld 408576698