Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422553008: Allow repack whitelist to be set via GN args (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow repack whitelist to be set via GN args BUG=551576 Committed: https://crrev.com/edbc7f9d90b7116357173f28b1b211937924a9a5 Cr-Commit-Position: refs/heads/master@{#358230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M build/secondary/tools/grit/repack.gni View 3 chunks +11 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Messages

Total messages: 8 (3 generated)
agrieve
On 2015/11/05 21:34:21, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:aurimas@chromium.org here's the second ...
5 years, 1 month ago (2015-11-05 21:34:37 UTC) #3
aurimas (slooooooooow)
lgtm
5 years, 1 month ago (2015-11-06 01:18:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422553008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422553008/1
5 years, 1 month ago (2015-11-06 01:29:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 02:04:23 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 02:05:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/edbc7f9d90b7116357173f28b1b211937924a9a5
Cr-Commit-Position: refs/heads/master@{#358230}

Powered by Google App Engine
This is Rietveld 408576698