Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264493004: GN (Android): Fix "ninja all" breaking on qcms_test for non-x86 (Closed)

Created:
5 years, 4 months ago by agrieve
Modified:
5 years, 4 months ago
Reviewers:
Noel Gordon
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN (Android): Fix "ninja all" breaking on qcms_test for non-x86 An executable with no sources causes a compile error. BUG=507294 Committed: https://crrev.com/964727399b69a0f6a4ff26db5ffea29b90719387 Cr-Commit-Position: refs/heads/master@{#341269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/qcms/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1268513005 Patch 1

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 4 months ago (2015-07-30 18:44:09 UTC) #2
Noel Gordon
LGTM
5 years, 4 months ago (2015-07-30 19:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264493004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264493004/1
5 years, 4 months ago (2015-07-31 01:22:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-31 02:06:33 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 02:07:19 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/964727399b69a0f6a4ff26db5ffea29b90719387
Cr-Commit-Position: refs/heads/master@{#341269}

Powered by Google App Engine
This is Rietveld 408576698