Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1321503003: Fix md5sum printing a stale checksum for missing files. (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
Reviewers:
Yaron, jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix md5sum printing a stale checksum for missing files. Also updates md5sum.py to detect when it needs to push a new version of md5sum_bin. BUG=520082 Committed: https://crrev.com/8a647a4bfe7cfca1b4992c6177edfc0514cfdd13 Cr-Commit-Position: refs/heads/master@{#346167}

Patch Set 1 #

Patch Set 2 : actually work #

Patch Set 3 : forgot if I already uploaded... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -55 lines) Patch
M build/android/pylib/utils/md5sum.py View 1 2 chunks +11 lines, -7 lines 0 comments Download
M build/android/pylib/utils/md5sum_test.py View 6 chunks +50 lines, -44 lines 0 comments Download
M tools/android/md5sum/md5sum.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1217063002 Patch 1

Dependent Patchsets:

Issue 1307393004 Patch 40001

Messages

Total messages: 8 (2 generated)
agrieve
yfriedman@chromium.org: Please review changes in tools/ jbudorick@chromium.org: Please review changes in build/
5 years, 3 months ago (2015-08-27 04:15:56 UTC) #2
Yaron
lgtm
5 years, 3 months ago (2015-08-27 14:19:49 UTC) #3
jbudorick
lgtm
5 years, 3 months ago (2015-08-27 15:11:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1321503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1321503003/40001
5 years, 3 months ago (2015-08-28 14:40:37 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-28 16:45:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 16:45:44 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8a647a4bfe7cfca1b4992c6177edfc0514cfdd13
Cr-Commit-Position: refs/heads/master@{#346167}

Powered by Google App Engine
This is Rietveld 408576698