GN Incremental Install: Add support for running with instrumentation.

GN Incremental Install: Add support for running with instrumentation.

BUG=540857, 520082
Committed: https://crrev.com/ad4636c52c09cc93608e6dcbb1e1d825ca269c9b
Cr-Commit-Position: refs/heads/master@{#354340}

[agrieve, 2015-10-15 00:53:35]

agrieve@chromium.org changed reviewers:
+ nyquist@chromium.org

[agrieve, 2015-10-15 00:54:09]

On 2015/10/15 00:53:35, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:nyquist@chromium.org

✿

[nyquist, 2015-10-15 19:05:16]

lgtm % the naming / comment things. I trust you to make it clear, but happy to
iterate over it here in the CL or over chat.

overall looks good though.

https://codereview.chromium.org/1409603002/diff/1/build/android/incremental_i...
File
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java
(right):

https://codereview.chromium.org/1409603002/diff/1/build/android/incremental_i...
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java:132:
void onInstrumentationCreate(Bundle arguments) {
As a layman it sounds like this method will only be called in the
instrumentation case, but in fact it's not. Do you think you could do something
with the naming or as a comment here, to make it clearer that it's also called
in the non-instrumentation case?

I mean, it's only the |mRealInstrumentation != null| block that's
instrumentation specific in this method (other than the fact that this whole
method of course is called from BootstrapInstrumentation).

[agrieve, 2015-10-15 19:20:48]

https://codereview.chromium.org/1409603002/diff/1/build/android/incremental_i...
File
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java
(right):

https://codereview.chromium.org/1409603002/diff/1/build/android/incremental_i...
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java:132:
void onInstrumentationCreate(Bundle arguments) {
On 2015/10/15 19:05:15, nyquist wrote:
> As a layman it sounds like this method will only be called in the
> instrumentation case, but in fact it's not. Do you think you could do
something
> with the naming or as a comment here, to make it clearer that it's also called
> in the non-instrumentation case?
> 
> I mean, it's only the |mRealInstrumentation != null| block that's
> instrumentation specific in this method (other than the fact that this whole
> method of course is called from BootstrapInstrumentation).

Left the name (as I couldn't think of a better one), but I've beefed up the
comments in a few places to make it more clear what's going on.

[agrieve, 2015-10-15 19:21:02]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-10-15 19:21:03]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1409603002/#ps20001
(title: "review 1")

[commit-bot: I haz the power, 2015-10-15 19:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409603002/20001

[commit-bot: I haz the power, 2015-10-15 20:31:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-15 20:32:42]

Patchset 2 (id:??) landed as
https://crrev.com/ad4636c52c09cc93608e6dcbb1e1d825ca269c9b
Cr-Commit-Position: refs/heads/master@{#354340}