Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 1231723002: Android GN: Include libstdc++.so when doing a component build (Closed)

Created:
5 years, 5 months ago by agrieve
Modified:
5 years, 5 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn11
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android GN: Include libstdc++.so when doing a component build BUG=500882 Committed: https://crrev.com/16c7c9e6dd49f0214c6de31fa0c5cf929bc0e12c Cr-Commit-Position: refs/heads/master@{#338512}

Patch Set 1 #

Patch Set 2 : remove duplicate vars in build/config/compiler/BUILD.gn #

Patch Set 3 : add via buildconfig instead so it appears in load list #

Patch Set 4 : strip libc++ #

Patch Set 5 : Fix create_native_executable_dist() not including lib paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M build/android/BUILD.gn View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
M build/android/gyp/write_ordered_libraries.py View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 4 3 chunks +7 lines, -7 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (8 generated)
agrieve
5 years, 5 months ago (2015-07-09 02:07:46 UTC) #2
cjhopman
lgtm
5 years, 5 months ago (2015-07-10 02:29:10 UTC) #3
agrieve
On 2015/07/10 02:29:10, cjhopman wrote: > lgtm Realized that I should be stripping the library ...
5 years, 5 months ago (2015-07-10 17:15:28 UTC) #4
agrieve
On 2015/07/10 17:15:28, agrieve wrote: > On 2015/07/10 02:29:10, cjhopman wrote: > > lgtm > ...
5 years, 5 months ago (2015-07-10 17:16:25 UTC) #5
cjhopman
still lgtm
5 years, 5 months ago (2015-07-10 22:49:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231723002/60001
5 years, 5 months ago (2015-07-11 01:55:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/72331) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-11 01:57:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231723002/60001
5 years, 5 months ago (2015-07-11 02:55:09 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/90690)
5 years, 5 months ago (2015-07-11 03:07:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231723002/80001
5 years, 5 months ago (2015-07-13 14:27:57 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-13 15:31:56 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 15:32:40 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/16c7c9e6dd49f0214c6de31fa0c5cf929bc0e12c
Cr-Commit-Position: refs/heads/master@{#338512}

Powered by Google App Engine
This is Rietveld 408576698