Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1374263002: Do not perform a non-incremental compile when previous compile failed. (Closed)

Created:
5 years, 2 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not perform a non-incremental compile when previous compile failed. This reverts a not-fully-thought-out change to md5_check.py from http://crrev.com/d8cef607861 Compiles fail for legitimate reasons, and we shouldn't delete md5 information in this case. The concern behind that logic in the first case was that buggy --incremental logic might be the reason for compile to fail. So, this commit also adds a new environment variable to force all targets to be rebuilt: FORCE_REBUILD=1 BUG=533442 Committed: https://crrev.com/a1ae0267dc973f87eecc864485be03f91613b86d Cr-Commit-Position: refs/heads/master@{#351345}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M build/android/gyp/util/md5_check.py View 3 chunks +4 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
On 2015/09/29 15:01:02, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ♤
5 years, 2 months ago (2015-09-29 15:01:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374263002/1
5 years, 2 months ago (2015-09-29 15:02:31 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 16:45:46 UTC) #6
Yaron
lgtm
5 years, 2 months ago (2015-09-29 16:48:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374263002/1
5 years, 2 months ago (2015-09-29 17:20:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 17:27:04 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 17:27:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1ae0267dc973f87eecc864485be03f91613b86d
Cr-Commit-Position: refs/heads/master@{#351345}

Powered by Google App Engine
This is Rietveld 408576698