GN: Enable incremental javac by default for debug builds

GN: Enable incremental javac by default for debug builds

BUG=536817

[agrieve, 2015-10-06 17:00:50]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2015-10-06 17:01:19]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2015-10-06 17:01:24]

On 2015/10/06 17:01:19, agrieve wrote:
> The CQ bit was checked by mailto:agrieve@chromium.org to run a CQ dry run

(‧”’‧)

[commit-bot: I haz the power, 2015-10-06 17:02:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1389013003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1389013003/1

[commit-bot: I haz the power, 2015-10-06 17:41:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-06 17:41:18]

Dry run: This issue passed the CQ dry run.

[Yaron, 2015-10-06 19:48:13]

yfriedman@chromium.org changed reviewers:
+ jbudorick@chromium.org

[Yaron, 2015-10-06 19:48:13]

+jbudorick

Could we try this on an FYI or experimental bot for a day or so to test it? GN
debug builds are on CQ, right?

[jbudorick, 2015-10-06 20:22:47]

On 2015/10/06 19:48:13, Yaron wrote:
> +jbudorick
> 
> Could we try this on an FYI or experimental bot for a day or so to test it? GN

I'd be fine with it, but I'll have to check to see if we have an FYI bot on GN.
I'm not sure how we'd test it on one of those bots without committing it,
though...

> debug builds are on CQ, right?

Yep:
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...

[Yaron, 2015-10-06 21:30:14]

On 2015/10/06 20:22:47, jbudorick wrote:
> On 2015/10/06 19:48:13, Yaron wrote:
> > +jbudorick
> > 
> > Could we try this on an FYI or experimental bot for a day or so to test it?
GN
> 
> I'd be fine with it, but I'll have to check to see if we have an FYI bot on
GN.
> I'm not sure how we'd test it on one of those bots without committing it,
> though...

Ugh. I can't find one. I checked the internal waterfall and we only have GN on
release. chromium.android and chromium.fyi both don't appear to have GN
builders. Still, this seems like it has the potential for Bad Things and would
like to *some* testing before we potentially break CQ. I was hoping that we
could set the GN config variable for just the one bot (i.e. check it in but not
put it on CQ)
> 
> > debug builds are on CQ, right?
> 
> Yep:
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...

[jbudorick, 2015-10-06 21:55:14]

On 2015/10/06 21:30:14, Yaron wrote:
> On 2015/10/06 20:22:47, jbudorick wrote:
> > On 2015/10/06 19:48:13, Yaron wrote:
> > > +jbudorick
> > > 
> > > Could we try this on an FYI or experimental bot for a day or so to test
it?
> GN
> > 
> > I'd be fine with it, but I'll have to check to see if we have an FYI bot on
> GN.
> > I'm not sure how we'd test it on one of those bots without committing it,
> > though...
> 
> Ugh. I can't find one. I checked the internal waterfall and we only have GN on
> release. chromium.android and chromium.fyi both don't appear to have GN
> builders. Still, this seems like it has the potential for Bad Things and would
> like to *some* testing before we potentially break CQ. I was hoping that we
> could set the GN config variable for just the one bot (i.e. check it in but
not
> put it on CQ)

How long would you theoretically be willing to wait to spin up a bot on
chromium.android?

> > 
> > > debug builds are on CQ, right?
> > 
> > Yep:
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...

[chromium-reviews, 2015-10-07 01:53:52]

I think this could be tested with a commit to the recipes instead (they set
the values of some GN args I think).

I'm happy to wait on this as there's no pressing need to enable it by
default. Having more bots testing GN would be awesome though!

On Tue, Oct 6, 2015 at 5:55 PM, <jbudorick@chromium.org> wrote:

> On 2015/10/06 21:30:14, Yaron wrote:
>
>> On 2015/10/06 20:22:47, jbudorick wrote:
>> > On 2015/10/06 19:48:13, Yaron wrote:
>> > > +jbudorick
>> > >
>> > > Could we try this on an FYI or experimental bot for a day or so to
>> test
>>
> it?
>
>> GN
>> >
>> > I'd be fine with it, but I'll have to check to see if we have an FYI
>> bot on
>> GN.
>> > I'm not sure how we'd test it on one of those bots without committing
>> it,
>> > though...
>>
>
> Ugh. I can't find one. I checked the internal waterfall and we only have
>> GN on
>> release. chromium.android and chromium.fyi both don't appear to have GN
>> builders. Still, this seems like it has the potential for Bad Things and
>> would
>> like to *some* testing before we potentially break CQ. I was hoping that
>> we
>> could set the GN config variable for just the one bot (i.e. check it in
>> but
>>
> not
>
>> put it on CQ)
>>
>
> How long would you theoretically be willing to wait to spin up a bot on
> chromium.android?
>
>
> >
>> > > debug builds are on CQ, right?
>> >
>> > Yep:
>> >
>>
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...
>
>
>
> https://codereview.chromium.org/1389013003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.